Fix built-in examples update during build #10844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the built-in examples assembly step of the build system set the
final_folder
parameter of theunzip
target to the true final installation location of the examples.The behavior of the
unzip
target is to only unzip the archive iffinal_folder
doesn't exist. Because that folder will exist any time a previous build has been done andant clean
was not run, the archive will not be unzipped. This causes the build to fail after an update to the built-in examples version when it attempts to copy the examples from theversion-dependent extraction staging folder to the final location.
The fix is to set the
final_folder
parameter to the version-dependent staging folder location, which will cause the extraction to happen every time the examples version is updated, but to be skipped when there was no update.See #10734 (comment) for an explanation of the problem, and the steps to reproduce it here: #10734 (comment). (Thanks matthijskooijman!)
All Submissions:
New Feature Submissions:
Changes to Core Features: